> On July 20, 2016, 5:22 p.m., Jason Lowe-Power wrote: > > I really like how these new config files are nice and encapsulated! I think > > this is the way forward for our config system. > > > > I have mostly minor comments below about a few ways to clean this up even > > more and use a more object-oriented design. Most comments can be ignored if > > you feel strongly against them. > > > > My biggest comment is that you should be using class constructors more. > > Just FYI, I've found (through trial and error) that you have to always have > > the following for SimObjects to work right (e.g., for SimpleSystem): > > > > class SimpleSystem(<super class>): > > def __init__(self, <other args>): > > super(SimpleSystem, self).__init__() > > <the rest of your constructor>
Hi Jason! Thanks for your comments, it's all very good feedback. I'll ask Gabor to have a look and update the configs. Unfortunately, we accidentally (due to some miscommunication) double posted this patch and committed it with a bunch of other things the other day. I don't think it's worth the noise to revert it and post an updated version as a separate commit, so the new version will be posted as an update. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3565/#review8489 ----------------------------------------------------------- On July 12, 2016, 8:16 a.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3565/ > ----------------------------------------------------------- > > (Updated July 12, 2016, 8:16 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11567:f22241c1afcc > --------------------------- > arm, config: Add an example ARM big.LITTLE(tm) configuration script > > An ARM big.LITTLE system consists of two cpu clusters: the big > CPUs are typically complex out-of-order cores and the little > CPUs are simpler in-order ones. The fs_bigLITTLE.py script > can run a full system simulation with various number of big > and little cores and cache hierarchy. The commit also includes > two example device tree files for booting Linux on the > bigLITTLE system. > > Change-Id: I6396fb3b2d8f27049ccae49d8666d643b66c088b > Reviewed-by: Andreas Sandberg <[email protected]> > > > Diffs > ----- > > configs/example/arm/fs_bigLITTLE.py PRE-CREATION > system/arm/dt/Makefile f050b8cf4754 > system/arm/dt/armv8_big_little.dts PRE-CREATION > configs/example/arm/devices.py PRE-CREATION > > Diff: http://reviews.gem5.org/r/3565/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
