----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3549/#review8502 -----------------------------------------------------------
Looks OK to me barring one minor issue. src/mem/protocol/Garnet_standalone-msg.sm (lines 36 - 42) <http://reviews.gem5.org/r/3549/#comment7377> Minor issue, but "most" of the -msg.sm files have these desc lines aligned. - Matthew Poremba On July 13, 2016, 7:02 a.m., Tushar Krishna wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3549/ > ----------------------------------------------------------- > > (Updated July 13, 2016, 7:02 a.m.) > > > Review request for Default, Andreas Hansson, Brad Beckmann, Jieming Yin, and > Matthew Poremba. > > > Repository: gem5 > > > Description > ------- > > garnet: rename ALPHA_Network_test protocol to Garnet_standalone. > Over the past 6 years, we realized that the protocol is essentially used > to run the garnet network in a standalone manner, and feed standard synthetic > traffic patterns through it. > > > Diffs > ----- > > src/mem/protocol/Network_test-dir.sm cdb94f2332a6 > src/mem/protocol/Network_test-msg.sm cdb94f2332a6 > src/mem/protocol/Network_test.slicc cdb94f2332a6 > src/mem/protocol/SConsopts cdb94f2332a6 > src/mem/ruby/system/GPUCoalescer.hh cdb94f2332a6 > src/mem/ruby/system/GPUCoalescer.cc cdb94f2332a6 > src/mem/ruby/system/Sequencer.hh cdb94f2332a6 > src/mem/ruby/system/Sequencer.cc cdb94f2332a6 > src/mem/ruby/system/Sequencer.py cdb94f2332a6 > configs/ruby/Garnet_standalone.py PRE-CREATION > configs/ruby/Network_test.py cdb94f2332a6 > src/mem/protocol/Garnet_standalone-cache.sm PRE-CREATION > src/mem/protocol/Garnet_standalone-dir.sm PRE-CREATION > src/mem/protocol/Garnet_standalone-msg.sm PRE-CREATION > src/mem/protocol/Garnet_standalone.slicc PRE-CREATION > src/mem/protocol/Network_test-cache.sm cdb94f2332a6 > build_opts/ALPHA_Network_test cdb94f2332a6 > build_opts/Garnet_standalone PRE-CREATION > > Diff: http://reviews.gem5.org/r/3549/diff/ > > > Testing > ------- > > > Thanks, > > Tushar Krishna > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
