----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3554/#review8506 -----------------------------------------------------------
Ship it! Looks good! I like this change. The Ruby.py file has been growing very large. - Matthew Poremba On July 13, 2016, 7:03 a.m., Tushar Krishna wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3554/ > ----------------------------------------------------------- > > (Updated July 13, 2016, 7:03 a.m.) > > > Review request for Default, Andreas Hansson, Brad Beckmann, Jieming Yin, and > Matthew Poremba. > > > Repository: gem5 > > > Description > ------- > > network: add a separate config file for the network. > This patch adds a new file configs/network/Network.py to setup the network, > instead of doing that within Ruby.py. > > > Diffs > ----- > > configs/example/apu_se.py cdb94f2332a6 > configs/example/fs.py cdb94f2332a6 > configs/example/garnet_synth_traffic.py PRE-CREATION > configs/example/ruby_direct_test.py cdb94f2332a6 > configs/example/ruby_gpu_random_test.py cdb94f2332a6 > configs/example/ruby_mem_test.py cdb94f2332a6 > configs/example/ruby_random_test.py cdb94f2332a6 > configs/example/se.py cdb94f2332a6 > configs/network/Network.py PRE-CREATION > configs/ruby/Ruby.py cdb94f2332a6 > > Diff: http://reviews.gem5.org/r/3554/diff/ > > > Testing > ------- > > > Thanks, > > Tushar Krishna > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
