> On juil. 23, 2016, 12:20 après-midi, Jason Lowe-Power wrote: > > LGTM, could you make sure that your description follows the fomatting > > guidelines (e.g., 65 char for the short description and 75 char per line in > > the long description). This makes it much easier for us to commit your > > patch :).
I updated the description to fit the formatting requirements :). - Nicolas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3582/#review8516 ----------------------------------------------------------- On juil. 23, 2016, 1:15 après-midi, Nicolas Derumigny wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3582/ > ----------------------------------------------------------- > > (Updated juil. 23, 2016, 1:15 après-midi) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > syscall_emu: Corrected a bug on the syscall "read()". > Read() should not write anything when returning 0 (EOF). > This patch does not correct the same bug occuring for : > > nbr_read=read(file, buf, nbytes) > > When nbr_read<nbytes, nbytes bytes are copied into the virtual > RAM instead of nbr_read. If buf is smaller than nbytes, a > page fault occurs, even if buf is in fact bigger than nbr_read. > > > Diffs > ----- > > src/sim/syscall_emul.cc cdb94f2332a6 > > Diff: http://reviews.gem5.org/r/3582/diff/ > > > Testing > ------- > > Works with CERE codelets (https://github.com/benchmark-subsetting/cere), > correcting the issue when replacing dumps in memory. > > > Thanks, > > Nicolas Derumigny > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
