> On July 25, 2016, 2:38 p.m., Jason Lowe-Power wrote: > > Maybe this should be two patches? One for the APU changes and one for the > > changes in to the physical memory. Why are the physical memory changes > > needed? > > > > Seems like maybe this should be "Enable KVM support for Ruby" and "kvm > > acceleration for apu...". > > > > Also, does KVM+Ruby+FS work now? Or just KVM+Ruby+SE? Or does this patch > > only make KVM+Ruby+SE work if you're using the APU? > > > > Thanks! I'm excited to see KVM+Ruby support coming.
I've gone ahead and split it into two patches along those lines (this patch for the src changes and /r/3584 for the config changes). The physical memory changes are needed so that KVM works with the --access-backing-store option, which creates a second copy of main memory for functional accesses. Previously, KVM would try to map all physical memories into the guest physical address range, which caused an error because it would map both copies of main memory onto the same range. Now KVM detects this situation using a heuristic and only maps the copy used for functional accesses onto the guest. So far I've only tested it with the apu_se.py script, but none of the C++ changes specifically rely on using an APU. I think that writing similar configuration code for example/se.py would work. I have not tested it with FS. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3580/#review8532 ----------------------------------------------------------- On July 22, 2016, 7:20 p.m., David Hashe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3580/ > ----------------------------------------------------------- > > (Updated July 22, 2016, 7:20 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11562:7375e1f533fa > --------------------------- > config, cpu, mem, sim: kvm acceleration for apu_se.py > > Add support for using KVM to accelerate APU simulations. The intended use > case is to fast-forward through runtime initialization until the first > kernel launch. > > > Diffs > ----- > > src/sim/system.cc 704b0198f747b766b839c577614eb2924fd1dfee > src/mem/physical.hh 704b0198f747b766b839c577614eb2924fd1dfee > src/mem/physical.cc 704b0198f747b766b839c577614eb2924fd1dfee > src/mem/ruby/system/Sequencer.cc 704b0198f747b766b839c577614eb2924fd1dfee > configs/example/apu_se.py 704b0198f747b766b839c577614eb2924fd1dfee > src/cpu/kvm/vm.cc 704b0198f747b766b839c577614eb2924fd1dfee > > Diff: http://reviews.gem5.org/r/3580/diff/ > > > Testing > ------- > > > Thanks, > > David Hashe > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
