----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3593/#review8596 -----------------------------------------------------------
Ship it! Ship It! - Andreas Sandberg On Aug. 4, 2016, 5:50 p.m., Michael LeBeane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3593/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2016, 5:50 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11559:99bab18e1728 > --------------------------- > sim: Refactor quiesce and remove FS asserts > The quiesce family of magic ops can be simplified by the inclusion of > quiesceTick() and quiesce() functions on ThreadContext. This patch also > gets rid of the FS guards, since suspending a CPU is also a valid > operation for SE mode. > > > Diffs > ----- > > src/cpu/o3/cpu.cc 91f58918a76abf1a1dedcaa70a9b95789da7b88c > src/cpu/simple_thread.cc 91f58918a76abf1a1dedcaa70a9b95789da7b88c > src/cpu/thread_context.hh 91f58918a76abf1a1dedcaa70a9b95789da7b88c > src/cpu/thread_context.cc 91f58918a76abf1a1dedcaa70a9b95789da7b88c > src/sim/pseudo_inst.cc 91f58918a76abf1a1dedcaa70a9b95789da7b88c > > Diff: http://reviews.gem5.org/r/3593/diff/ > > > Testing > ------- > > > Thanks, > > Michael LeBeane > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
