Hi Andreas, yes, this looks like it. In fact, I was fearing something like this, but since the regression tests appear to have some custom configuration (IIRC at least the binary images must have been modified not to wait for the user to type "boot" at the ok prompt), I did not see a way to verify that.
The fact that the regression tests seem to count on the fact that auto boot is enabled makes it more difficult to integrate a different regression test (for example the one at https://code.launchpad.net/~jakub/helenos/gem5-sparc-fs-regression-test which uses expect to achieve the same on the original OpenSPARC obp binaries). Jakub On 08/10/2016 06:49 PM, Andreas Sandberg wrote: > It seems like this commit has some unforeseen interactions with the > regressions system. The SPARC FS regression doesn’t seem to run at all on > Zizzer anymore. When I run the 80.solaris-boot test locally (without the disk > image), I get a failure with the “Don't know what default disk image to use > for sparc ISA” error instead of the regression being skipped. > > I think this is caused by the commit below removing the default image that > the regressions rely on. Adding it to configs/common/Benchmarks.py /should/ > solve the issue. > > //Andreas > > On 19/07/2016, 15:55, "gem5-dev on behalf of Jakub Jermar" > <[email protected]<mailto:[email protected]> on behalf of > [email protected]<mailto:[email protected]>> wrote: > > changeset 1040cd2252d4 in /z/repo/gem5 > details: http://repo.gem5.org/gem5?cmd=changeset;node=1040cd2252d4 > description: > config: Allow SPARC FS image to be specified on the command line > > At the moment the SPARC FS machine configuration comes with a > hardcoded > value for using the Solaris 10 disk image from the OpenSPARC tarball. > The > --disk-image option is completely ignored for SPARC. This simple patch > modifies the behavior so that --disk-image option is both taken into > account and also required. This makes it possible to easily change > SPARC FS > images without having to modify the configuration files. > > diffstat: > > configs/common/FSConfig.py | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diffs (12 lines): > > diff -r a16337161285 -r 1040cd2252d4 configs/common/FSConfig.py > --- a/configs/common/FSConfig.py Tue Jul 19 09:48:56 2016 -0500 > +++ b/configs/common/FSConfig.py Tue Jul 19 09:52:46 2016 -0500 > @@ -169,7 +169,7 @@ > self.partition_desc.port = self.membus.master > self.intrctrl = IntrControl() > self.disk0 = CowMmDisk() > - self.disk0.childImage(disk('disk.s10hw2')) > + self.disk0.childImage(mdesc.disk()) > self.disk0.pio = self.iobus.master > # The puart0 and hvuart are placed on the IO bus, so create ranges > _______________________________________________ > gem5-dev mailing list > [email protected]<mailto:[email protected]> > http://m5sim.org/mailman/listinfo/gem5-dev > > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > contents to any other person, use it for any purpose, or store or copy the > information in any medium. Thank you. > _______________________________________________ > gem5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/gem5-dev > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
