----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3580/#review8602 -----------------------------------------------------------
src/mem/AbstractMemory.py (line 64) <http://reviews.gem5.org/r/3580/#comment7485> I am still trying to wrap my head around what the table looks like with in_addr_map, conf_table_Reported, and now kvm_map, for "real memories", "device memories", "shadow memories" etc. We technically have 8 different types of memories now, but I suspect we only really have three. Could we perhaps enumerate them and call that out in the comments. Perhaps we should consider an enum rather? src/mem/abstract_mem.hh (line 120) <http://reviews.gem5.org/r/3580/#comment7484> could you make this const, and the two other bools as well? src/mem/physical.cc (line 82) <http://reviews.gem5.org/r/3580/#comment7482> whitespace src/mem/physical.cc (line 200) <http://reviews.gem5.org/r/3580/#comment7483> while you are at it, change to .emplace_back(range, pmem, kvm_map) - Andreas Hansson On Aug. 5, 2016, 9:37 p.m., David Hashe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3580/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2016, 9:37 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11562:7375e1f533fa > --------------------------- > cpu, mem, sim: Enable KVM support for Ruby > > Only map memories into the KVM guest address space that are > marked as usable by KVM. > > Remember whether a BackingStoreEntry should be mapped by KVM. > > Fix bug causing incomplete draining of Ruby Sequencer. > > > Diffs > ----- > > src/cpu/kvm/vm.cc 704b0198f747b766b839c577614eb2924fd1dfee > src/mem/AbstractMemory.py 704b0198f747b766b839c577614eb2924fd1dfee > src/mem/abstract_mem.hh 704b0198f747b766b839c577614eb2924fd1dfee > src/mem/abstract_mem.cc 704b0198f747b766b839c577614eb2924fd1dfee > src/mem/physical.hh 704b0198f747b766b839c577614eb2924fd1dfee > src/mem/physical.cc 704b0198f747b766b839c577614eb2924fd1dfee > > Diff: http://reviews.gem5.org/r/3580/diff/ > > > Testing > ------- > > > Thanks, > > David Hashe > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
