----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3599/#review8674 -----------------------------------------------------------
Ship it! Ship It! - Jason Lowe-Power On Aug. 11, 2016, 9:07 a.m., Curtis Dunham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3599/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2016, 9:07 a.m.) > > > Review request for Default and Matthias Jung. > > > Repository: gem5 > > > Description > ------- > > mem: Sort memory commands and update DRAMPower > > Add local variable to stores commands to be issued. > These commands are in order within a single bank but will be out > of order across banks & ranks. > > A new procedure, flushCmdList, sorts commands across banks / ranks, > and flushes the sorted list, up to curTick() to DRAMPower. > This is currently called in refresh, once all previous commands are > guaranteed to have completed. Could be called in other events like > the powerEvent as well. > > By only flushing commands up to curTick(), will not get out of sync > when flushed at a periodic stats dump (done in subsequent patch). > > Change-Id: I4ac65a52407f64270db1e16a1fb04cfe7f638851 > Reviewed-by: Radhika Jagtap <radhika.jag...@arm.com> > > > Diffs > ----- > > src/mem/dram_ctrl.hh e9096175eb38ac39f37c91bfdf2a450b9664e222 > src/mem/dram_ctrl.cc e9096175eb38ac39f37c91bfdf2a450b9664e222 > > Diff: http://reviews.gem5.org/r/3599/diff/ > > > Testing > ------- > > > Thanks, > > Curtis Dunham > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
