-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3625/
-----------------------------------------------------------

Review request for Default.


Repository: gem5


Description
-------

Changeset 11636:a027301cec6d
---------------------------
util: git pre-commit hook to check staged files

This patch updates the git-pre-commit hook to check the files as they
will be after the commit, instead of as they are currently, this way we
prevent the undesired situation:
    - unstylish modification of a file
    - stage said file for commit
    - try to commit and fail due to style
    - fix style, forgetting staging changes
    - try to commit and fail, as although the changes staged are not
      styly, the current content of the file is.

Change-Id: I5cc3f783375d9e4162e310e176103ebbf0a59023
Reviewed-by: Andreas Sandberg <andreas.sandb...@arm.com>
[andreas.sandb...@arm.com: Rebased ontop of latest gem5]


Diffs
-----

  util/git-pre-commit.py e92bf392bf43 
  util/style/verifiers.py e92bf392bf43 

Diff: http://reviews.gem5.org/r/3625/diff/


Testing
-------


Thanks,

Andreas Sandberg

_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to