> On Aug. 31, 2016, 5:04 p.m., Michael LeBeane wrote:
> > Any more comments on this?  We would like to get a few more ship it's since 
> > this fairly large and will break checkpoints.
> 
> Andreas Hansson wrote:
>     If it breaks checkpoints there should be an update function added, or am 
> I missing something?

Hmmm, I could add an update function but I don't have any checkpoints to test 
it with.  Does anyone have any checkpoints out there with serialized packets?  
Or are there some easy networking workloads that could be used to generate some 
test checkpoints?


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3493/#review8696
-----------------------------------------------------------


On June 29, 2016, 6:27 p.m., Michael LeBeane wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3493/
> -----------------------------------------------------------
> 
> (Updated June 29, 2016, 6:27 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> -------
> 
> Changeset 11549:573a7d349538
> ---------------------------
> dev: Redefine 'length' in EthPacketData
> Currently, all the network devices create a 16K buffer for the 'data' field
> in EthPacketData, and use 'length' to keep track of the size of the packet
> in the buffer.  This patch introduces 'dataLength' and 'simLength' parameters
> to EthPacketData. 'dataLength' stores the amount of space taken up by the
> packet in the 'data' buffer. 'simLength' is used to hold the effective length
> of the packet used for all timing calulations in the simulator.  Serialization
> is performed using only the useful data in the packet ('dataLength') and not
> necessarily the entire original buffer.
> 
> 
> Diffs
> -----
> 
>   src/dev/net/etherswitch.cc 91f58918a76abf1a1dedcaa70a9b95789da7b88c 
>   src/dev/net/ethertap.cc 91f58918a76abf1a1dedcaa70a9b95789da7b88c 
>   src/dev/net/i8254xGBe.cc 91f58918a76abf1a1dedcaa70a9b95789da7b88c 
>   src/dev/net/ns_gige.cc 91f58918a76abf1a1dedcaa70a9b95789da7b88c 
>   src/dev/net/pktfifo.hh 91f58918a76abf1a1dedcaa70a9b95789da7b88c 
>   src/dev/net/pktfifo.cc 91f58918a76abf1a1dedcaa70a9b95789da7b88c 
>   src/dev/net/sinic.cc 91f58918a76abf1a1dedcaa70a9b95789da7b88c 
>   src/dev/net/tcp_iface.cc 91f58918a76abf1a1dedcaa70a9b95789da7b88c 
>   src/dev/net/etherbus.cc 91f58918a76abf1a1dedcaa70a9b95789da7b88c 
>   src/dev/net/etherdump.cc 91f58918a76abf1a1dedcaa70a9b95789da7b88c 
>   src/dev/net/etherlink.cc 91f58918a76abf1a1dedcaa70a9b95789da7b88c 
>   src/dev/net/etherpkt.hh 91f58918a76abf1a1dedcaa70a9b95789da7b88c 
>   src/dev/net/etherpkt.cc 91f58918a76abf1a1dedcaa70a9b95789da7b88c 
>   src/dev/net/dist_etherlink.cc 91f58918a76abf1a1dedcaa70a9b95789da7b88c 
>   src/dev/net/dist_iface.cc 91f58918a76abf1a1dedcaa70a9b95789da7b88c 
>   src/dev/net/dist_packet.hh 91f58918a76abf1a1dedcaa70a9b95789da7b88c 
> 
> Diff: http://reviews.gem5.org/r/3493/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael LeBeane
> 
>

_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to