----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3634/#review8758 -----------------------------------------------------------
Ship it! Ship It! - Jason Lowe-Power On Oct. 3, 2016, 5:40 a.m., Alexandru Dutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3634/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2016, 5:40 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11653:beaa9af9fada > --------------------------- > gpu-compute: Added method to compute the actual workgroup size > This patch adds a method to the Wavefront class to compute the actual > workgroup > size. This can be different from the maximum workgroup size specified when > launching the kernel through the NDRange object. Current solution is still not > optimal, as we are computing these for each wavefront and the dispatcher also > needs to have this information and can't actually call > Wavefront::computeActuallWgSz before the wavefronts are being created. A long > term solution would be to have a Workgroup class that deals with all these > details. > > > Diffs > ----- > > src/gpu-compute/wavefront.cc 2c111e634da005e2b78981fadd0368662454f2ed > src/gpu-compute/compute_unit.hh 2c111e634da005e2b78981fadd0368662454f2ed > src/gpu-compute/compute_unit.cc 2c111e634da005e2b78981fadd0368662454f2ed > src/gpu-compute/wavefront.hh 2c111e634da005e2b78981fadd0368662454f2ed > > Diff: http://reviews.gem5.org/r/3634/diff/ > > > Testing > ------- > > Regressions pass. > > > Thanks, > > Alexandru Dutu > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
