----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3644/#review8775 -----------------------------------------------------------
Ship it! Ship It! - Alexandru Dutu On Oct. 6, 2016, 2:14 a.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3644/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2016, 2:14 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11663:8d1c14f262e9 > --------------------------- > gpu-compute: remove inst enums and use bit flag for attributes > > this patch removes the GPUStaticInst enums that were defined in GPU.py. > instead, > a simple set of attribute flags that can be set in the base instruction class > are used. this will help unify the attributes of HSAIL and other possible ISA > instructions within the model itself. > > because the static instrution now carries the attributes, a GPUDynInst > must carry a pointer to a valid GPUStaticInst so a new static kernel launch > instruction is added, which carries the attributes needed to perform a > the kernel launch. > > > Diffs > ----- > > src/gpu-compute/kernel_cfg.cc b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/gpu-compute/lds_state.hh b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/gpu-compute/lds_state.cc b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/gpu-compute/gpu_static_inst.hh b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/gpu-compute/gpu_static_inst.cc b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/gpu-compute/wavefront.cc b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/gpu-compute/local_memory_pipeline.cc > b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/gpu-compute/shader.hh b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/gpu-compute/vector_register_file.cc > b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/arch/hsail/SConscript b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/arch/hsail/generic_types.hh b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/arch/hsail/generic_types.cc b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/arch/hsail/insts/branch.hh b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/arch/hsail/insts/decl.hh b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/arch/hsail/insts/main.cc b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/arch/hsail/insts/mem.hh b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/arch/hsail/insts/mem.cc b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/arch/hsail/insts/mem_impl.hh b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/arch/hsail/insts/pseudo_inst.cc > b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/gpu-compute/GPU.py b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/gpu-compute/GPUStaticInstFlags.py PRE-CREATION > src/gpu-compute/SConscript b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/gpu-compute/code_enums.hh b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/gpu-compute/compute_unit.hh b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/gpu-compute/compute_unit.cc b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/gpu-compute/global_memory_pipeline.cc > b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/gpu-compute/gpu_dyn_inst.hh b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/gpu-compute/gpu_dyn_inst.cc b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > > Diff: http://reviews.gem5.org/r/3644/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
