----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3645/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 11671:7933c7d74368 --------------------------- hsail, gpu-compute: remove doGm/SmReturn from gm/lm pipe add completeAcc we are removing doGmReturn from the GM pipe, and adding completeAcc() implementations for the HSAIL mem ops. the behavior in doGmReturn is dependent on HSAIL and HSAIL mem ops, however the completion phase of memory ops in machine ISA can be very different, even amongst individual machine ISA mem ops. so we remove this functionality from the pipeline and allow it to be implemented by the individual instructions. Diffs ----- src/gpu-compute/gpu_dyn_inst.cc 10d59d546ea236b24b8f8261ffa22bfc8a0c736c src/gpu-compute/local_memory_pipeline.hh 10d59d546ea236b24b8f8261ffa22bfc8a0c736c src/gpu-compute/local_memory_pipeline.cc 10d59d546ea236b24b8f8261ffa22bfc8a0c736c src/arch/hsail/insts/mem.hh 10d59d546ea236b24b8f8261ffa22bfc8a0c736c src/gpu-compute/global_memory_pipeline.hh 10d59d546ea236b24b8f8261ffa22bfc8a0c736c src/gpu-compute/global_memory_pipeline.cc 10d59d546ea236b24b8f8261ffa22bfc8a0c736c src/gpu-compute/gpu_dyn_inst.hh 10d59d546ea236b24b8f8261ffa22bfc8a0c736c Diff: http://reviews.gem5.org/r/3645/diff/ Testing ------- Thanks, Tony Gutierrez _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
