> On Oct. 7, 2016, 4:16 p.m., Jason Lowe-Power wrote: > > util/style.py, line 117 > > <http://reviews.gem5.org/r/3648/diff/1/?file=58366#file58366line117> > > > > I'm going to be picky here... Can you change this to the below so you > > don't have the awkward newline when printing the help text. > > > > ``` > > help="Style checkers to run. Can be specified " > > "multiple times." > > ``` > > Andreas Sandberg wrote: > Argparse actually ignores this newline. There is a help formatter thingy > that removes newlines and generally cleans up indentation. We actually have a > custom formatter in tests/tests.py to make it print paragraphs correctly in > the usage epilog. > > Jason Lowe-Power wrote: > I didn't know that. Thanks for informing me. > > We should pick one or the other and put it in the style guide. I see a > mix of both throughout the codebase. I would personally rather not use the > triple quotes to keep things consistent between python and C/C++. Thoughts?
I'm not too bothered about C++ and Python being consistent. In general, we should follow the official Python style guide (there is such a thing) for Python files. Otherwise, we end up with weird looking Python code. It's not possible to do consistently though because the C++ world "leaks" into Python. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3648/#review8783 ----------------------------------------------------------- On Oct. 7, 2016, 4:11 p.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3648/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2016, 4:11 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11669:258c76f88f24 > --------------------------- > style: Add options to select checkers and apply fixes > > Add an option, --checker/-c, to style.py that selects individual style > checkers to apply. When this option isn't specified, the script > defaults to all available style checkers. The option may be specified > multiple times to run multiple style checkers. > > The option, --fix/-f, can be specified to automatically fix style > violations. > > Change-Id: Id7597fba6b65cecfa17a88b1c87c8a4c8315af59 > Signed-off-by: Andreas Sandberg <andreas.sandb...@arm.com> > Reviewed-by: Andreas Hansson <andreas.hans...@arm.com> > > > Diffs > ----- > > util/style.py 380375085863 > > Diff: http://reviews.gem5.org/r/3648/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
