----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3595/#review8830 -----------------------------------------------------------
Ship it! Ship it! Thanks for the fixes! - Gabor Dozsa On Oct. 12, 2016, 3:51 p.m., Michael LeBeane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3595/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2016, 3:51 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11561:1414a40eb1e2 > --------------------------- > dev: Add m5 op to toggle synchronization for dist-gem5. > This patch adds the ability for an application to request dist-gem5 to begin/ > end synchronization using an m5 op. When toggling on sync, all nodes agree on > the next sync point based on the maximum of all nodes' ticks. CPUs are > suspended until the sync point to avoid sending network messages until sync > has > been enabled. Toggling off sync acts like a global execution barrier, where > all CPUs are disabled until every node reaches the toggle off point. This > avoids tricky situations such as one node hitting a toggle off followed by a > toggle on before the other nodes hit the first toggle off. > > > Diffs > ----- > > util/m5/m5op_x86.S e92bf392bf4302e2e88e19907e7fc981f59e777d > util/m5/m5ops.h e92bf392bf4302e2e88e19907e7fc981f59e777d > util/m5/m5op.h e92bf392bf4302e2e88e19907e7fc981f59e777d > src/dev/net/dist_iface.hh e92bf392bf4302e2e88e19907e7fc981f59e777d > src/dev/net/dist_etherlink.cc e92bf392bf4302e2e88e19907e7fc981f59e777d > src/arch/x86/isa/decoder/two_byte_opcodes.isa > e92bf392bf4302e2e88e19907e7fc981f59e777d > src/dev/net/Ethernet.py e92bf392bf4302e2e88e19907e7fc981f59e777d > configs/common/Options.py e92bf392bf4302e2e88e19907e7fc981f59e777d > src/sim/pseudo_inst.cc e92bf392bf4302e2e88e19907e7fc981f59e777d > src/sim/pseudo_inst.hh e92bf392bf4302e2e88e19907e7fc981f59e777d > src/dev/net/tcp_iface.cc e92bf392bf4302e2e88e19907e7fc981f59e777d > src/dev/net/tcp_iface.hh e92bf392bf4302e2e88e19907e7fc981f59e777d > src/dev/net/dist_packet.hh e92bf392bf4302e2e88e19907e7fc981f59e777d > src/dev/net/dist_iface.cc e92bf392bf4302e2e88e19907e7fc981f59e777d > > Diff: http://reviews.gem5.org/r/3595/diff/ > > > Testing > ------- > > > Thanks, > > Michael LeBeane > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
