----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3663/#review8832 -----------------------------------------------------------
Ship it! I noticed one small thing, no need to repost. Thanks for doing this. I agree that the whole configs directory needs some major re-working. I think most of it should be rewritten. There is no reason for us to have a single FSConfig.py file to define all possible full system options for all of the possible ISA/OS combinations. These scripts could all be much more modular / follow object-oriented design patterns. I'll put this on the list of things that we could do at the sprint at HPCA :). configs/learning_gem5/part1/two_level.py (line 49) <http://reviews.gem5.org/r/3663/#comment7616> Should this be `../../`? - Jason Lowe-Power On Oct. 13, 2016, 2:10 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3663/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2016, 2:10 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11671:6e5527f38e5b > --------------------------- > config: Make configs/common a Python package > > Continue along the same line as the recent patch that made the > Ruby-related config scripts Python packages and make also the > configs/common directory a package. > > All affected config scripts are updated (hopefully). > > Note that this change makes it apparent that the current organisation > and naming of the config directory and its subdirectories is rather > chaotic. We mix scripts that are directly invoked with scripts that > merely contain convenience functions. While it is not addressed in > this patch we should follow up with a re-organisation of the > config structure, and renaming of some of the packages. > > > Diffs > ----- > > configs/common/__init__.py 6ce719503eae > configs/dist/sw.py 6ce719503eae > configs/dram/lat_mem_rd.py 6ce719503eae > configs/dram/sweep.py 6ce719503eae > configs/example/apu_se.py 6ce719503eae > configs/example/arm/devices.py 6ce719503eae > configs/example/arm/fs_bigLITTLE.py 6ce719503eae > configs/example/etrace_replay.py 6ce719503eae > configs/example/fs.py 6ce719503eae > configs/example/garnet_synth_traffic.py 6ce719503eae > configs/example/hmctest.py 6ce719503eae > configs/example/ruby_direct_test.py 6ce719503eae > configs/example/ruby_gpu_random_test.py 6ce719503eae > configs/example/ruby_mem_test.py 6ce719503eae > configs/example/ruby_random_test.py 6ce719503eae > configs/example/se.py 6ce719503eae > configs/learning_gem5/part1/caches.py 6ce719503eae > configs/learning_gem5/part1/two_level.py 6ce719503eae > configs/ruby/Ruby.py 6ce719503eae > configs/splash2/cluster.py 6ce719503eae > configs/splash2/run.py 6ce719503eae > tests/configs/alpha_generic.py 6ce719503eae > tests/configs/arm_generic.py 6ce719503eae > tests/configs/base_config.py 6ce719503eae > tests/configs/checkpoint.py 6ce719503eae > tests/configs/gpu-randomtest-ruby.py 6ce719503eae > tests/configs/gpu-ruby.py 6ce719503eae > tests/configs/learning-gem5-p1-two-level.py 6ce719503eae > tests/configs/memtest-filter.py 6ce719503eae > tests/configs/memtest-ruby.py 6ce719503eae > tests/configs/memtest.py 6ce719503eae > tests/configs/o3-timing-mp-ruby.py 6ce719503eae > tests/configs/o3-timing-mt.py 6ce719503eae > tests/configs/o3-timing-ruby.py 6ce719503eae > tests/configs/o3-timing.py 6ce719503eae > tests/configs/pc-simple-timing-ruby.py 6ce719503eae > tests/configs/rubytest-ruby.py 6ce719503eae > tests/configs/simple-timing-mp-ruby.py 6ce719503eae > tests/configs/simple-timing-ruby.py 6ce719503eae > tests/configs/switcheroo.py 6ce719503eae > tests/configs/t1000-simple-atomic.py 6ce719503eae > tests/configs/twosys-tsunami-simple-atomic.py 6ce719503eae > tests/configs/x86_generic.py 6ce719503eae > > Diff: http://reviews.gem5.org/r/3663/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
