-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3664/#review8839
-----------------------------------------------------------

Ship it!



src/mem/ruby/system/GPUCoalescer.cc (line 877)
<http://reviews.gem5.org/r/3664/#comment7618>

    IIRC, you can do `reqCoalescer[line_addr].emplace_back(pkt, primary_type, 
secondary_type);` to avoid a copy constructor call. No big deal while this is a 
simple object, but if it gets more complex, it may matter in the future. It's 
up to you if you want to change it.
    
    This assumes that we have C++11 support, which I think all of our supported 
compilers have.


- Jason Lowe-Power


On Oct. 13, 2016, 9:24 p.m., Tony Gutierrez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3664/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2016, 9:24 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> -------
> 
> Changeset 11855:f99c307b574e
> ---------------------------
> ruby: make a RequestDesc class instead of std::pair
> 
> the RequestDesc was previously implemented as a std::pair, which made
> the implementation overly complex and error prone. here we encapsulate the
> packet, primary, and secondary types all in a single data structure with
> all members properly intialized in a ctor
> 
> 
> Diffs
> -----
> 
>   src/mem/ruby/system/GPUCoalescer.hh 
> b29aca3fcb75f5ad92429001ab11c65b2f9635b0 
>   src/mem/ruby/system/GPUCoalescer.cc 
> b29aca3fcb75f5ad92429001ab11c65b2f9635b0 
> 
> Diff: http://reviews.gem5.org/r/3664/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tony Gutierrez
> 
>

_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to