----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3643/#review8863 -----------------------------------------------------------
Ship it! Ship It! - Michael LeBeane On Oct. 17, 2016, 3:12 p.m., Brandon Potter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3643/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2016, 3:12 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11691:ba6ddbf68d8c > --------------------------- > style: [patch 3/22] reduce include dependencies in some headers > > Used cppclean to help identify useless includes and removed them. This > involved erroneously included headers, but also cases where forward > declarations could have been used rather than a full include. > > > Diffs > ----- > > src/arch/alpha/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/arch/alpha/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/arch/alpha/tru64/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/arch/arm/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/arch/arm/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/arch/mips/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/arch/mips/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/arch/power/interrupts.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/arch/power/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/arch/power/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/arch/power/remote_gdb.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/arch/sparc/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/arch/sparc/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/arch/x86/isa_traits.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/arch/x86/pagetable.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/arch/x86/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/arch/x86/pseudo_inst.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/arch/x86/system.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/arch/x86/system.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/arch/x86/tlb.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/arch/x86/tlb.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/arch/x86/utility.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/arch/x86/utility.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/base/bitfield.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/base/bitunion.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/base/time.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/base/vnc/vncinput.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/cpu/minor/buffers.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/cpu/testers/directedtest/InvalidateGenerator.cc > 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/cpu/testers/directedtest/RubyDirectedTester.cc > 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/cpu/testers/directedtest/SeriesRequestGenerator.cc > 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/cpu/testers/rubytest/Check.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/cpu/testers/rubytest/CheckTable.cc > 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/dev/arm/flash_device.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/dev/mc146818.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/dev/net/dist_iface.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/dev/net/etherbus.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/dev/net/etherswitch.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/kern/linux/linux.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/kern/linux/linux.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/mem/cache/prefetch/stride.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/mem/external_master.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/mem/external_slave.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/mem/mem_checker.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/mem/multi_level_page_table.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/mem/multi_level_page_table_impl.hh > 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/mem/page_table.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/mem/page_table.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/mem/ruby/network/MessageBuffer.hh > 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/mem/ruby/structures/AbstractReplacementPolicy.cc > 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/mem/se_translating_port_proxy.hh > 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/mem/simple_mem.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/python/swig/pyevent.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/SConscript 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/arguments.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/arguments.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/byteswap.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/clock_domain.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/clocked_object.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/cxx_config.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/cxx_config_ini.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/cxx_config_ini.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/cxx_manager.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/drain.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/dvfs_handler.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/dvfs_handler.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/eventq.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/fd_entry.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/init_signals.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/insttracer.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/microcode_rom.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/microcode_rom.cc PRE-CREATION > src/sim/power/mathexpr_powermodel.hh > 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/power/power_model.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/power/power_model.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/power/thermal_domain.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/power/thermal_domain.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/power/thermal_entity.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/power/thermal_model.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/probe/probe.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/probe/probe.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/process_impl.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/serialize.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/sim_exit.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/sim_object.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/sim_object.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/simulate.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/stat_register.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/stat_register.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/sub_system.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/syscall_emul.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/syscall_emul.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/syscall_return.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/system.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/ticked_object.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/ticked_object.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/voltage_domain.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/vptr.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > > Diff: http://reviews.gem5.org/r/3643/diff/ > > > Testing > ------- > > util/regress > > > Thanks, > > Brandon Potter > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
