> On Oct. 17, 2016, 5:18 p.m., Alexandru Dutu wrote:
> > src/sim/process.cc, line 453
> > <http://reviews.gem5.org/r/3670/diff/2/?file=61577#file61577line453>
> >
> >     Same goes for unserialization.

Thanks for pointing this out, but there are more fields than this missing from 
the checkpoints. The checkpoint support has been broken in SE for a while now 
so I doubt that anyone actually uses it. If they have, I'd like to know about 
it. (As an aside, we need to bake the checkpoint testing into the regressions 
if we want to keep support for them.)

Checkpoints are hard to support with some of the stuff that's getting added. 
(I'd appreciate it if I could get the go ahead to completely break it (well, 
more so than already) in the near term.) Need to discuss it more generally with 
a separate thread on gem5-dev to cover the complications and get feedback on 
how to handle them.


- Brandon


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3670/#review8873
-----------------------------------------------------------


On Oct. 17, 2016, 3:14 p.m., Brandon Potter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3670/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2016, 3:14 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> -------
> 
> Changeset 11692:ba60e4ae816f
> ---------------------------
> syscall_emul: [patch 4/22] remove redundant M5_pid field from process
> 
> 
> Diffs
> -----
> 
>   src/sim/system.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/system.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/Process.py 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/sparc/faults.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/alpha/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
> 
> Diff: http://reviews.gem5.org/r/3670/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to