-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3655/#review8909
-----------------------------------------------------------


Any comments? I'm planning on shipping this soon.

- Tony Gutierrez


On Oct. 10, 2016, 11:34 a.m., Tony Gutierrez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3655/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2016, 11:34 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> -------
> 
> Changeset 11680:b7ba41787b5d
> ---------------------------
> gpu-compute, hsail: make the PC a byte address, not an instruction index
> 
> currently the PC is incremented on an instruction granularity, and not as an
> instruction's byte address. machine ISA instructions assume the PC is a byte
> address, and is incremented accordingly. here we make the GPU model, and the
> HSAIL instructions treat the PC as a byte address as well.
> 
> 
> Diffs
> -----
> 
>   src/arch/hsail/gpu_isa.hh PRE-CREATION 
>   src/arch/hsail/gpu_types.hh 220fa4099b9a91526b8a1828f27cf1a9f3c15837 
>   src/arch/hsail/insts/branch.hh 220fa4099b9a91526b8a1828f27cf1a9f3c15837 
>   src/arch/hsail/insts/gpu_static_inst.hh 
> 220fa4099b9a91526b8a1828f27cf1a9f3c15837 
>   src/gpu-compute/cl_driver.cc 220fa4099b9a91526b8a1828f27cf1a9f3c15837 
>   src/gpu-compute/fetch_unit.cc 220fa4099b9a91526b8a1828f27cf1a9f3c15837 
>   src/gpu-compute/gpu_static_inst.hh 220fa4099b9a91526b8a1828f27cf1a9f3c15837 
>   src/gpu-compute/gpu_static_inst.cc 220fa4099b9a91526b8a1828f27cf1a9f3c15837 
>   src/gpu-compute/hsail_code.cc 220fa4099b9a91526b8a1828f27cf1a9f3c15837 
>   src/gpu-compute/kernel_cfg.hh 220fa4099b9a91526b8a1828f27cf1a9f3c15837 
>   src/gpu-compute/kernel_cfg.cc 220fa4099b9a91526b8a1828f27cf1a9f3c15837 
> 
> Diff: http://reviews.gem5.org/r/3655/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tony Gutierrez
> 
>

_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to