----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3652/#review8911 -----------------------------------------------------------
Any comments? I'm planning on shipping this soon. - Tony Gutierrez On Oct. 10, 2016, 11:24 a.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3652/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2016, 11:24 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11679:5695d76ec68b > --------------------------- > gpu-compute: use the GPUISA object to advance the PC > > the GPU model treats the PC as a pointer to individual instruction objects - > which are store in a contiguous array - and not a byte address to be fetched > from the real memory system. this is ok for HSAIL because all instructions are > considered by the model to be the same size. > > in machine ISA, however, instructions may be 32b or 64b, and branches are > calculated by advancing the PC by the number of words (4 byte chunks) it > needs to advance in the real instruction stream. because of this there is > a mismatch between the PC we use to index into the instruction array, and > the actual byte address PC the ISA expects. here we move the PC advance > calculation to the ISA so that differences in the instrucion sizes may be > accounted for in generic way. > > > Diffs > ----- > > src/gpu-compute/fetch_unit.cc 220fa4099b9a91526b8a1828f27cf1a9f3c15837 > src/gpu-compute/wavefront.cc 220fa4099b9a91526b8a1828f27cf1a9f3c15837 > > Diff: http://reviews.gem5.org/r/3652/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
