----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3662/ -----------------------------------------------------------
(Updated Oct. 19, 2016, 10:30 p.m.) Review request for Default. Repository: gem5 Description (updated) ------- Changeset 11691:111bd8a24517 --------------------------- syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc The class was crammed into syscall_emul.hh which has tons of forward declarations and template definitions. To clean it up a bit, moved the class into separate files and commented the class with doxygen style comments. Also, provided some encapsulation by adding some accessors and a mutator. The syscallreturn.hh file was renamed syscall_return.hh to make it consistent with other similarly named files in the src/sim directory. The DPRINTF_SYSCALL macro was moved into its own header file with the include the Base and Verbose flags as well. Diffs (updated) ----- src/arch/alpha/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/arch/arm/freebsd/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/arch/arm/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/arch/mips/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/arch/power/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/arch/sparc/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/arch/sparc/linux/syscalls.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/arch/sparc/solaris/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/arch/x86/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/arch/x86/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/kern/tru64/tru64.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/sim/SConscript 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/sim/syscall_debug_macros.hh PRE-CREATION src/sim/syscall_desc.hh PRE-CREATION src/sim/syscall_desc.cc PRE-CREATION src/sim/syscall_emul.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/sim/syscall_emul.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/sim/syscallreturn.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 Diff: http://reviews.gem5.org/r/3662/diff/ Testing ------- Thanks, Brandon Potter _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
