----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3658/#review8950 -----------------------------------------------------------
Ship it! Neat refactoring! Other than the python arg name, this looks good to me. configs/example/apu_se.py (line 156) <http://reviews.gem5.org/r/3658/#comment7691> Shouldn't we stick to the dash naming style instead of camel case? src/gpu-compute/global_memory_pipeline.hh <http://reviews.gem5.org/r/3658/#comment7690> Neat fix! The next two methods should also go away, however that is not something to be considered for this patch. - Alexandru Dutu On Oct. 10, 2016, 11:51 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3658/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2016, 11:51 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11683:e48e281afdd8 > --------------------------- > gpu-compute: support in-order data delivery in GM pipe > > this patch adds an ordered response buffer to the GM pipeline > to ensure in-order data delivery. the buffer is implemented as > a stl ordered map, which sorts the request in program order by > using their sequence ID. when requests return to the GM pipeline > they are marked as done. only the oldest request may be serviced > from the ordered buffer, and only if is marked as done. > > the FIFO response buffers are kept and used in OoO delivery mode > > > Diffs > ----- > > src/gpu-compute/GPU.py 220fa4099b9a91526b8a1828f27cf1a9f3c15837 > src/gpu-compute/compute_unit.cc 220fa4099b9a91526b8a1828f27cf1a9f3c15837 > src/gpu-compute/global_memory_pipeline.hh > 220fa4099b9a91526b8a1828f27cf1a9f3c15837 > src/gpu-compute/global_memory_pipeline.cc > 220fa4099b9a91526b8a1828f27cf1a9f3c15837 > configs/example/apu_se.py 220fa4099b9a91526b8a1828f27cf1a9f3c15837 > src/arch/hsail/insts/decl.hh 220fa4099b9a91526b8a1828f27cf1a9f3c15837 > src/arch/hsail/insts/mem_impl.hh 220fa4099b9a91526b8a1828f27cf1a9f3c15837 > src/arch/hsail/insts/pseudo_inst.cc > 220fa4099b9a91526b8a1828f27cf1a9f3c15837 > > Diff: http://reviews.gem5.org/r/3658/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
