----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3692/#review9044 -----------------------------------------------------------
Ship it! This fixed some problems I've seen when running. - Joe Gross On Nov. 1, 2016, 5:55 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3692/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2016, 5:55 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11889:b236bb4bd2ce > --------------------------- > gpu-compute: fix segfault when constructing GPUExecContext > > the GPUExecContext context currently stores a reference to its parent WF's > GPUISA object, however there are some special instructions that do not have > an associated WF. when these objects are constructed they set their WF pointer > to null, which causes the GPUExecContext to segfault when trying to > dereference > the WF pointer to get at the WF's GPUISA object. here we change the GPUISA > reference in the GPUExecContext class to a pointer so that it may be set to > null. > > > Diffs > ----- > > src/gpu-compute/gpu_exec_context.hh > c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/gpu-compute/gpu_exec_context.cc > c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > > Diff: http://reviews.gem5.org/r/3692/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
