----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3698/#review9061 -----------------------------------------------------------
Ship it! Looks good. Please add a bit more to the commit message saying what functionality you are adding (etc/passwd special file, etc.). - Michael LeBeane On Nov. 7, 2016, 10:07 p.m., Brandon Potter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3698/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2016, 10:07 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11706:693893fbee1f > --------------------------- > syscall_emul: [PATCH 17/22] refactor and add functionality to open syscall > family > > > Diffs > ----- > > src/arch/x86/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/kern/linux/linux.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/kern/linux/linux.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/syscall_emul.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > > Diff: http://reviews.gem5.org/r/3698/diff/ > > > Testing > ------- > > > Thanks, > > Brandon Potter > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
