> On Nov. 16, 2016, 6:19 p.m., Jason Lowe-Power wrote: > > BTW, how are you finding all these bugs? Do you have some test suite you're > > running which exercises all of these syscalls?
No, I don't have a test suite for it. It's not really a bug in that it wouldn't do the "right" thing either; it's just that we have the convention or returning -errno for failed system calls. I don't know why it was missing from the code in the first place. - Brandon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3707/#review9090 ----------------------------------------------------------- On Nov. 16, 2016, 4:25 p.m., Brandon Potter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3707/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2016, 4:25 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11727:e576e1bd7cd6 > --------------------------- > syscall_emul: return -errno on a failed close call > > > Diffs > ----- > > src/sim/syscall_emul.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > > Diff: http://reviews.gem5.org/r/3707/diff/ > > > Testing > ------- > > > Thanks, > > Brandon Potter > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
