> On Nov. 14, 2016, 5:41 p.m., Brandon Potter wrote: > > src/arch/alpha/kernel_stats.cc, line 185 > > <http://reviews.gem5.org/r/3688/diff/1/?file=62591#file62591line185> > > > > I think that all that the stats do is record mode switches between user > > and kernel space. There's a small tracker for kvm switches in arm, but this > > doesn't look like very useful information outside of someone needing it for > > a publication. At least, it's not useful enough to implement for other > > architectures apparently. The other architectures only have stubs for this > > class: src/arch/*/kernel_stats.hh. > > > > Instead of worrying about the maintenance, can we remove this and stop > > tracking the kernel stats altogether? (If it is deemed useful, it probably > > needs to be implemented for the other architectures too.)
ok, i suggest we move forward with the current patch as is and then take it from there. could i get a few ship its? - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3688/#review9047 ----------------------------------------------------------- On Oct. 27, 2016, 7:45 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3688/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2016, 7:45 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11705:6c2b4e24accf > --------------------------- > alpha: Remove ALPHA tru64 support and associated tests > > No one appears to be using it, and it is causing build issues > and increases the development and maintenance effort. > > > Diffs > ----- > > tests/long/se/30.eon/ref/alpha/tru64/o3-timing/stats.txt c38fcdaa5fe5 > tests/long/se/30.eon/ref/alpha/tru64/simple-timing/config.ini c38fcdaa5fe5 > tests/long/se/30.eon/ref/alpha/tru64/simple-timing/simerr c38fcdaa5fe5 > tests/long/se/30.eon/ref/alpha/tru64/simple-timing/simout c38fcdaa5fe5 > tests/long/se/30.eon/ref/alpha/tru64/simple-timing/stats.txt c38fcdaa5fe5 > tests/long/se/40.perlbmk/ref/alpha/tru64/minor-timing/config.ini > c38fcdaa5fe5 > tests/long/se/40.perlbmk/ref/alpha/tru64/minor-timing/simerr c38fcdaa5fe5 > tests/long/se/40.perlbmk/ref/alpha/tru64/minor-timing/simout c38fcdaa5fe5 > tests/long/se/40.perlbmk/ref/alpha/tru64/minor-timing/stats.txt > c38fcdaa5fe5 > tests/long/se/40.perlbmk/ref/alpha/tru64/o3-timing/config.ini c38fcdaa5fe5 > tests/long/se/40.perlbmk/ref/alpha/tru64/o3-timing/simerr c38fcdaa5fe5 > tests/long/se/40.perlbmk/ref/alpha/tru64/o3-timing/simout c38fcdaa5fe5 > tests/long/se/40.perlbmk/ref/alpha/tru64/o3-timing/stats.txt c38fcdaa5fe5 > tests/long/se/40.perlbmk/ref/alpha/tru64/simple-atomic/config.ini > c38fcdaa5fe5 > tests/long/se/40.perlbmk/ref/alpha/tru64/simple-atomic/simerr c38fcdaa5fe5 > tests/long/se/40.perlbmk/ref/alpha/tru64/simple-atomic/simout c38fcdaa5fe5 > tests/long/se/40.perlbmk/ref/alpha/tru64/simple-atomic/stats.txt > c38fcdaa5fe5 > tests/long/se/40.perlbmk/ref/alpha/tru64/simple-timing/config.ini > c38fcdaa5fe5 > tests/long/se/40.perlbmk/ref/alpha/tru64/simple-timing/simerr c38fcdaa5fe5 > tests/long/se/40.perlbmk/ref/alpha/tru64/simple-timing/simout c38fcdaa5fe5 > tests/long/se/40.perlbmk/ref/alpha/tru64/simple-timing/stats.txt > c38fcdaa5fe5 > tests/long/se/50.vortex/ref/alpha/tru64/minor-timing/config.ini > c38fcdaa5fe5 > tests/long/se/50.vortex/ref/alpha/tru64/minor-timing/simerr c38fcdaa5fe5 > tests/long/se/50.vortex/ref/alpha/tru64/minor-timing/simout c38fcdaa5fe5 > tests/long/se/50.vortex/ref/alpha/tru64/minor-timing/stats.txt c38fcdaa5fe5 > tests/long/se/50.vortex/ref/alpha/tru64/o3-timing/config.ini c38fcdaa5fe5 > tests/long/se/50.vortex/ref/alpha/tru64/o3-timing/simerr c38fcdaa5fe5 > tests/long/se/50.vortex/ref/alpha/tru64/o3-timing/simout c38fcdaa5fe5 > tests/long/se/50.vortex/ref/alpha/tru64/o3-timing/smred.msg c38fcdaa5fe5 > tests/long/se/50.vortex/ref/alpha/tru64/o3-timing/smred.out c38fcdaa5fe5 > tests/long/se/50.vortex/ref/alpha/tru64/o3-timing/stats.txt c38fcdaa5fe5 > tests/long/se/60.bzip2/ref/alpha/tru64/minor-timing/config.ini c38fcdaa5fe5 > tests/long/se/60.bzip2/ref/alpha/tru64/minor-timing/simerr c38fcdaa5fe5 > tests/long/se/60.bzip2/ref/alpha/tru64/minor-timing/simout c38fcdaa5fe5 > tests/long/se/60.bzip2/ref/alpha/tru64/minor-timing/stats.txt c38fcdaa5fe5 > tests/long/se/60.bzip2/ref/alpha/tru64/o3-timing/config.ini c38fcdaa5fe5 > tests/long/se/60.bzip2/ref/alpha/tru64/o3-timing/simerr c38fcdaa5fe5 > tests/long/se/60.bzip2/ref/alpha/tru64/o3-timing/simout c38fcdaa5fe5 > tests/long/se/60.bzip2/ref/alpha/tru64/o3-timing/stats.txt c38fcdaa5fe5 > tests/long/se/60.bzip2/ref/alpha/tru64/simple-atomic/config.ini > c38fcdaa5fe5 > tests/long/se/60.bzip2/ref/alpha/tru64/simple-atomic/simerr c38fcdaa5fe5 > tests/long/se/60.bzip2/ref/alpha/tru64/simple-atomic/simout c38fcdaa5fe5 > tests/long/se/60.bzip2/ref/alpha/tru64/simple-atomic/stats.txt c38fcdaa5fe5 > tests/long/se/60.bzip2/ref/alpha/tru64/simple-timing/config.ini > c38fcdaa5fe5 > tests/long/se/60.bzip2/ref/alpha/tru64/simple-timing/simerr c38fcdaa5fe5 > tests/long/se/60.bzip2/ref/alpha/tru64/simple-timing/simout c38fcdaa5fe5 > tests/long/se/60.bzip2/ref/alpha/tru64/simple-timing/stats.txt c38fcdaa5fe5 > tests/long/se/70.twolf/ref/alpha/tru64/minor-timing/config.ini c38fcdaa5fe5 > tests/long/se/70.twolf/ref/alpha/tru64/minor-timing/simerr c38fcdaa5fe5 > tests/long/se/70.twolf/ref/alpha/tru64/minor-timing/simout c38fcdaa5fe5 > tests/long/se/70.twolf/ref/alpha/tru64/minor-timing/stats.txt c38fcdaa5fe5 > tests/long/se/70.twolf/ref/alpha/tru64/o3-timing/config.ini c38fcdaa5fe5 > tests/long/se/70.twolf/ref/alpha/tru64/o3-timing/simerr c38fcdaa5fe5 > tests/long/se/70.twolf/ref/alpha/tru64/o3-timing/simout c38fcdaa5fe5 > tests/long/se/30.eon/ref/alpha/tru64/o3-timing/config.ini c38fcdaa5fe5 > tests/long/se/30.eon/ref/alpha/tru64/o3-timing/simerr c38fcdaa5fe5 > tests/long/se/30.eon/ref/alpha/tru64/o3-timing/simout c38fcdaa5fe5 > src/arch/alpha/AlphaSystem.py c38fcdaa5fe5 > src/arch/alpha/SConscript c38fcdaa5fe5 > src/arch/alpha/kernel_stats.cc c38fcdaa5fe5 > src/arch/alpha/tru64/process.hh c38fcdaa5fe5 > src/arch/alpha/tru64/process.cc c38fcdaa5fe5 > src/arch/alpha/tru64/system.hh c38fcdaa5fe5 > src/arch/alpha/tru64/system.cc c38fcdaa5fe5 > src/arch/alpha/tru64/tru64.hh c38fcdaa5fe5 > src/arch/alpha/tru64/tru64.cc c38fcdaa5fe5 > src/kern/SConscript c38fcdaa5fe5 > src/kern/kernel_stats.hh c38fcdaa5fe5 > src/kern/kernel_stats.cc c38fcdaa5fe5 > src/kern/tru64/dump_mbuf.hh c38fcdaa5fe5 > src/kern/tru64/dump_mbuf.cc c38fcdaa5fe5 > src/kern/tru64/mbuf.hh c38fcdaa5fe5 > src/kern/tru64/printf.hh c38fcdaa5fe5 > src/kern/tru64/printf.cc c38fcdaa5fe5 > src/kern/tru64/tru64.hh c38fcdaa5fe5 > src/kern/tru64/tru64_events.hh c38fcdaa5fe5 > src/kern/tru64/tru64_events.cc c38fcdaa5fe5 > src/kern/tru64/tru64_syscalls.hh c38fcdaa5fe5 > src/kern/tru64/tru64_syscalls.cc c38fcdaa5fe5 > src/sim/process.cc c38fcdaa5fe5 > tests/long/se/20.parser/ref/alpha/tru64/NOTE c38fcdaa5fe5 > tests/long/se/20.parser/ref/alpha/tru64/minor-timing/config.ini > c38fcdaa5fe5 > tests/long/se/20.parser/ref/alpha/tru64/minor-timing/simerr c38fcdaa5fe5 > tests/long/se/20.parser/ref/alpha/tru64/minor-timing/simout c38fcdaa5fe5 > tests/long/se/20.parser/ref/alpha/tru64/minor-timing/stats.txt c38fcdaa5fe5 > tests/long/se/30.eon/ref/alpha/tru64/minor-timing/config.ini c38fcdaa5fe5 > tests/long/se/30.eon/ref/alpha/tru64/minor-timing/simerr c38fcdaa5fe5 > tests/long/se/30.eon/ref/alpha/tru64/minor-timing/simout c38fcdaa5fe5 > tests/long/se/30.eon/ref/alpha/tru64/minor-timing/stats.txt c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby-MOESI_CMP_directory/stats.txt > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby-MOESI_CMP_token/config.ini > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby-MOESI_CMP_token/simerr > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby-MOESI_CMP_token/simout > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby-MOESI_CMP_token/stats.txt > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby-MOESI_hammer/config.ini > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby-MOESI_hammer/simerr > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby-MOESI_hammer/simout > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby-MOESI_hammer/stats.txt > c38fcdaa5fe5 > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby/config.ini > c38fcdaa5fe5 > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby/simerr > c38fcdaa5fe5 > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby/simout > c38fcdaa5fe5 > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby/stats.txt > c38fcdaa5fe5 > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing/config.ini > c38fcdaa5fe5 > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing/simerr c38fcdaa5fe5 > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing/simout c38fcdaa5fe5 > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing/stats.txt > c38fcdaa5fe5 > tests/quick/se/30.eon/ref/alpha/tru64/simple-atomic/config.ini c38fcdaa5fe5 > tests/quick/se/30.eon/ref/alpha/tru64/simple-atomic/simerr c38fcdaa5fe5 > tests/quick/se/30.eon/ref/alpha/tru64/simple-atomic/simout c38fcdaa5fe5 > tests/quick/se/30.eon/ref/alpha/tru64/simple-atomic/stats.txt c38fcdaa5fe5 > tests/quick/se/50.vortex/ref/alpha/tru64/simple-atomic/config.ini > c38fcdaa5fe5 > tests/quick/se/50.vortex/ref/alpha/tru64/simple-atomic/simerr c38fcdaa5fe5 > tests/quick/se/50.vortex/ref/alpha/tru64/simple-atomic/simout c38fcdaa5fe5 > tests/quick/se/50.vortex/ref/alpha/tru64/simple-atomic/smred.msg > c38fcdaa5fe5 > tests/quick/se/50.vortex/ref/alpha/tru64/simple-atomic/smred.out > c38fcdaa5fe5 > tests/quick/se/50.vortex/ref/alpha/tru64/simple-atomic/stats.txt > c38fcdaa5fe5 > tests/quick/se/50.vortex/ref/alpha/tru64/simple-timing/config.ini > c38fcdaa5fe5 > tests/quick/se/50.vortex/ref/alpha/tru64/simple-timing/simerr c38fcdaa5fe5 > tests/quick/se/50.vortex/ref/alpha/tru64/simple-timing/simout c38fcdaa5fe5 > tests/quick/se/50.vortex/ref/alpha/tru64/simple-timing/smred.msg > c38fcdaa5fe5 > tests/quick/se/50.vortex/ref/alpha/tru64/simple-timing/smred.out > c38fcdaa5fe5 > tests/quick/se/50.vortex/ref/alpha/tru64/simple-timing/stats.txt > c38fcdaa5fe5 > tests/quick/se/70.twolf/ref/alpha/tru64/simple-atomic/config.ini > c38fcdaa5fe5 > tests/quick/se/70.twolf/ref/alpha/tru64/simple-atomic/simerr c38fcdaa5fe5 > tests/quick/se/70.twolf/ref/alpha/tru64/simple-atomic/simout c38fcdaa5fe5 > tests/quick/se/70.twolf/ref/alpha/tru64/simple-atomic/smred.out > c38fcdaa5fe5 > tests/quick/se/70.twolf/ref/alpha/tru64/simple-atomic/smred.pin > c38fcdaa5fe5 > tests/quick/se/70.twolf/ref/alpha/tru64/simple-atomic/smred.pl1 > c38fcdaa5fe5 > tests/quick/se/70.twolf/ref/alpha/tru64/simple-atomic/smred.pl2 > c38fcdaa5fe5 > tests/quick/se/70.twolf/ref/alpha/tru64/simple-atomic/smred.sav > c38fcdaa5fe5 > tests/quick/se/70.twolf/ref/alpha/tru64/simple-atomic/smred.sv2 > c38fcdaa5fe5 > tests/quick/se/70.twolf/ref/alpha/tru64/simple-atomic/smred.twf > c38fcdaa5fe5 > tests/quick/se/70.twolf/ref/alpha/tru64/simple-atomic/stats.txt > c38fcdaa5fe5 > tests/quick/se/70.twolf/ref/alpha/tru64/simple-timing/config.ini > c38fcdaa5fe5 > tests/quick/se/70.twolf/ref/alpha/tru64/simple-timing/simerr c38fcdaa5fe5 > tests/quick/se/70.twolf/ref/alpha/tru64/simple-timing/simout c38fcdaa5fe5 > tests/quick/se/70.twolf/ref/alpha/tru64/simple-timing/smred.out > c38fcdaa5fe5 > tests/quick/se/70.twolf/ref/alpha/tru64/simple-timing/smred.pin > c38fcdaa5fe5 > tests/quick/se/70.twolf/ref/alpha/tru64/simple-timing/smred.pl1 > c38fcdaa5fe5 > tests/quick/se/70.twolf/ref/alpha/tru64/simple-timing/smred.pl2 > c38fcdaa5fe5 > tests/quick/se/70.twolf/ref/alpha/tru64/simple-timing/smred.sav > c38fcdaa5fe5 > tests/quick/se/70.twolf/ref/alpha/tru64/simple-timing/smred.sv2 > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby-MOESI_CMP_directory/simout > c38fcdaa5fe5 > tests/long/se/70.twolf/ref/alpha/tru64/o3-timing/smred.out c38fcdaa5fe5 > tests/long/se/70.twolf/ref/alpha/tru64/o3-timing/smred.pin c38fcdaa5fe5 > tests/long/se/70.twolf/ref/alpha/tru64/o3-timing/smred.pl1 c38fcdaa5fe5 > tests/long/se/70.twolf/ref/alpha/tru64/o3-timing/smred.pl2 c38fcdaa5fe5 > tests/long/se/70.twolf/ref/alpha/tru64/o3-timing/smred.sav c38fcdaa5fe5 > tests/long/se/70.twolf/ref/alpha/tru64/o3-timing/smred.sv2 c38fcdaa5fe5 > tests/long/se/70.twolf/ref/alpha/tru64/o3-timing/smred.twf c38fcdaa5fe5 > tests/long/se/70.twolf/ref/alpha/tru64/o3-timing/stats.txt c38fcdaa5fe5 > tests/quick/se/00.hello/ref/alpha/tru64/minor-timing/config.ini > c38fcdaa5fe5 > tests/quick/se/00.hello/ref/alpha/tru64/minor-timing/simerr c38fcdaa5fe5 > tests/quick/se/00.hello/ref/alpha/tru64/minor-timing/simout c38fcdaa5fe5 > tests/quick/se/00.hello/ref/alpha/tru64/minor-timing/stats.txt c38fcdaa5fe5 > tests/quick/se/00.hello/ref/alpha/tru64/o3-timing/config.ini c38fcdaa5fe5 > tests/quick/se/00.hello/ref/alpha/tru64/o3-timing/simerr c38fcdaa5fe5 > tests/quick/se/00.hello/ref/alpha/tru64/o3-timing/simout c38fcdaa5fe5 > tests/quick/se/00.hello/ref/alpha/tru64/o3-timing/stats.txt c38fcdaa5fe5 > tests/quick/se/00.hello/ref/alpha/tru64/simple-atomic/config.ini > c38fcdaa5fe5 > tests/quick/se/00.hello/ref/alpha/tru64/simple-atomic/simerr c38fcdaa5fe5 > tests/quick/se/00.hello/ref/alpha/tru64/simple-atomic/simout c38fcdaa5fe5 > tests/quick/se/00.hello/ref/alpha/tru64/simple-atomic/stats.txt > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby-MESI_Two_Level/config.ini > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby-MESI_Two_Level/simerr > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby-MESI_Two_Level/simout > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby-MESI_Two_Level/stats.txt > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby-MOESI_CMP_directory/config.ini > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby-MOESI_CMP_directory/simerr > c38fcdaa5fe5 > tests/quick/se/70.twolf/ref/alpha/tru64/simple-timing/smred.twf > c38fcdaa5fe5 > tests/quick/se/70.twolf/ref/alpha/tru64/simple-timing/stats.txt > c38fcdaa5fe5 > tests/test-progs/hello/bin/alpha/tru64/hello c38fcdaa5fe5 > > Diff: http://reviews.gem5.org/r/3688/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
