----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3708/#review9099 -----------------------------------------------------------
Ship it! Looks good. You might want to consider changing the way the reset callback is created to remove an unnecessary class though. src/mem/probes/mem_footprint.cc (line 87) <http://reviews.gem5.org/r/3708/#comment7849> You could actually do this instead of using a custom class: ``` registerResetCallback(new MakeCallback<MemFootprintProbe, &MemFootprintProbe::statReset>(this)) ``` - Andreas Sandberg On Nov. 16, 2016, 11:02 p.m., Rahul Thakur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3708/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2016, 11:02 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11705:df194a470063 > --------------------------- > commit 752c67b134f4cb0b7ca68a907c39a5a482de30b3 > Author: Rahul Thakur <[email protected]> > Date: Thu Oct 27 17:44:40 2016 -0700 > > mem: Add memory footprint probe > > Change-Id: I0fba8995edd63df4ef49969347be6d2aefceca9f > > > Diffs > ----- > > src/mem/probes/mem_footprint.hh PRE-CREATION > src/mem/probes/mem_footprint.cc PRE-CREATION > COPYING c38fcdaa5fe5 > configs/dram/lat_mem_rd.py c38fcdaa5fe5 > src/mem/probes/MemFootprintProbe.py PRE-CREATION > src/mem/probes/SConscript c38fcdaa5fe5 > > Diff: http://reviews.gem5.org/r/3708/diff/ > > > Testing > ------- > > > Thanks, > > Rahul Thakur > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
