----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3716/#review9111 -----------------------------------------------------------
Ship it! Minor issue - as I'm pretty sure clang will flag this - otherwise it looks good. src/arch/hsail/insts/decl.hh (line 762) <http://reviews.gem5.org/r/3716/#comment7853> These should all be marked as override, correct? - Tony Gutierrez On Nov. 17, 2016, 12:28 p.m., Brandon Potter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3716/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2016, 12:28 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11709:7aeedaa99901 > --------------------------- > hsail: add stub type and stub out several instructions > > > Diffs > ----- > > src/arch/hsail/gen.py c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/arch/hsail/insts/decl.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > > Diff: http://reviews.gem5.org/r/3716/diff/ > > > Testing > ------- > > > Thanks, > > Brandon Potter > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
