----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3717/#review9112 -----------------------------------------------------------
Ship it! Minor issue. src/arch/hsail/operand.cc (line 327) <http://reviews.gem5.org/r/3717/#comment7854> remove the assert as opposed to commenting it out - Tony Gutierrez On Nov. 17, 2016, 12:27 p.m., Brandon Potter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3717/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2016, 12:27 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11710:05a4d1bea8d9 > --------------------------- > hsail: disable asserts to allow immediate operands i.e. 0 with loads > > > Diffs > ----- > > src/arch/hsail/operand.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > > Diff: http://reviews.gem5.org/r/3717/diff/ > > > Testing > ------- > > > Thanks, > > Brandon Potter > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
