----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3712/#review9113 -----------------------------------------------------------
Ship it! Ship It! - Tony Gutierrez On Nov. 17, 2016, 12:25 p.m., Brandon Potter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3712/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2016, 12:25 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11705:3dbaf4ac9c81 > --------------------------- > hsail: remove the panic guarding function directives > > HSA functions calls are still not supported properly with HSAIL, but > the recent AMP runtime modifications rely on being able to parse the > BRIG/HSAIL files that are extracted from the application binaries. > We need to parse the function call HSAIL definitions, but we do not > actually need to make the function calls. > > The reason that this happens is that HCC appends a set of routines > to every HSAIL binary that it creates. These extra, unnecessary > routines exist in the HCC source as a file; this file is cat'd onto > everything that the compiler outputs before being assembled into the > application's binary. HCC does this because it might call these helper > functions. However, it doesn't actually appear to do so in the AMP > codes so we just parse these functions with the HSAIL parser and > then ignore them. > > > Diffs > ----- > > src/gpu-compute/brig_object.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > > Diff: http://reviews.gem5.org/r/3712/diff/ > > > Testing > ------- > > > Thanks, > > Brandon Potter > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
