----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3725/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 11710:e6fc84b08039 --------------------------- mem: Service only the 1st FromCPU MSHR target on ReadRespWithInv A response to a ReadReq can either be a ReadResp or a ReadRespWithInvalidate. As we add targets to an MSHR for a ReadReq we assume that the response will be a ReadResp. When the response is invalidating (ReadRespWithInvalidate) servicing more than one targets can potentially violate the memory ordering. This change fixes the way we handle a ReadRespWithInvalidate. When a cache receives a ReadRespWithInvalidate we service only the first FromCPU target and all the FromSnoop targets from the MSHR target list. The rest of the FromCPU targets are deferred and serviced by a new request. Change-Id: I75c30c268851987ee5f8644acb46f440b4eeeec2 Reviewed-by: Andreas Hansson <[email protected]> Reviewed-by: Stephan Diestelhorst <[email protected]> Diffs ----- src/mem/cache/cache.cc 1d085f66c4ca src/mem/cache/mshr.hh 1d085f66c4ca src/mem/cache/mshr.cc 1d085f66c4ca Diff: http://reviews.gem5.org/r/3725/diff/ Testing ------- Thanks, Nikos Nikoleris _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
