----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3695/#review9126 -----------------------------------------------------------
Thanks for sorting all this out. Could you extend the patch description as there is a lot going on in this patch, both in terms of refactoring and adding new functionality? In the future it would be good to split these changes, e.g. "use pkg-config for SystemC example", "make command line interface modular" etc. - Andreas Hansson On Nov. 10, 2016, 5:07 p.m., Christian Menard wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3695/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2016, 5:07 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11709:a64e6cc90f4e > --------------------------- > misc: final cleanup of the TLM modules > > Introduce new transactor modules. These modules rerpresent the gem5 TLM ports > in the SystemC world. Common code in the examples is moved to a common dir. > > > Diffs > ----- > > util/tlm/examples/common/cli_parser.hh PRE-CREATION > util/tlm/examples/common/cli_parser.cc PRE-CREATION > util/tlm/examples/common/report_handler.hh PRE-CREATION > util/tlm/examples/common/report_handler.cc PRE-CREATION > util/tlm/examples/master_port/SConstruct PRE-CREATION > util/tlm/examples/master_port/main.cc PRE-CREATION > util/tlm/examples/master_port/tlm.py PRE-CREATION > util/tlm/examples/master_port/traffic_generator.cc PRE-CREATION > util/tlm/examples/slave_port/SConstruct PRE-CREATION > util/tlm/examples/slave_port/main.cc PRE-CREATION > util/tlm/examples/slave_port/sc_target.cc PRE-CREATION > util/tlm/examples/slave_port/tlm.py PRE-CREATION > util/tlm/gem5_master_transactor.hh PRE-CREATION > util/tlm/gem5_master_transactor.cc PRE-CREATION > util/tlm/gem5_slave_transactor.hh PRE-CREATION > util/tlm/gem5_slave_transactor.cc PRE-CREATION > util/tlm/sc_master_port.hh PRE-CREATION > util/tlm/sc_master_port.cc PRE-CREATION > util/tlm/sc_slave_port.hh PRE-CREATION > util/tlm/sc_slave_port.cc PRE-CREATION > util/tlm/sim_control.hh PRE-CREATION > util/tlm/sim_control.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/3695/diff/ > > > Testing > ------- > > Examples compile and run. > > > Thanks, > > Christian Menard > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
