----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3721/#review9139 -----------------------------------------------------------
Thoughts? I would like to ship this today. - Tony Gutierrez On Nov. 17, 2016, 12:54 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3721/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2016, 12:54 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11892:35849c921444 > --------------------------- > x86: fix issue with casting in Cvtf2i > > UBSAN flags this operation because it detects that arg is being cast directly > to an unsigned type, argBits. this patch fixes this by first casting the > value to a signed int type, then reintrepreting the raw bits of the signed > int into argBits. > > > Diffs > ----- > > src/arch/x86/isa/microops/mediaop.isa > c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > > Diff: http://reviews.gem5.org/r/3721/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev