> On Nov. 15, 2016, 2:03 a.m., Alexandru Dutu wrote: > > src/sim/process.cc, line 148 > > <http://reviews.gem5.org/r/3696/diff/2/?file=63554#file63554line148> > > > > Does memState need to be dynamically allocated?
Yes, the memState need to be able to be dynamically created and shared between Processes to simulate threads. > On Nov. 15, 2016, 2:03 a.m., Alexandru Dutu wrote: > > src/sim/syscall_emul.hh, line 1220 > > <http://reviews.gem5.org/r/3696/diff/2/?file=63556#file63556line1220> > > > > Should these commented lines be removed? I'm leaving them in place in case someone wants to implement this for sparc. The registers don't show up in the header file for sparc and I had a bit of trouble the compiler to not complain about them. Also, I only put effort in getting the pthread support to work for x86. The other ISAs still need work, but the code should compile for all of them now. > On Nov. 15, 2016, 2:03 a.m., Alexandru Dutu wrote: > > src/sim/syscall_emul.hh, line 1768 > > <http://reviews.gem5.org/r/3696/diff/2/?file=63556#file63556line1768> > > > > Ranged for will work here as well. fds is not an iterable class - Brandon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3696/#review9071 ----------------------------------------------------------- On Nov. 14, 2016, 8:37 p.m., Brandon Potter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3696/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2016, 8:37 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11722:6fea3eedd891 > --------------------------- > syscall_emul: [PATCH 15/22] add clone/execve for threading and multiprocess > simulations > > Modifies the clone system call and adds execve system call. Requires allowing > processes to steal thread contexts from other processes in the same system > object and the ability to detach pieces of process state (such as MemState) > to allow dynamic sharing. > > > Diffs > ----- > > src/sim/syscall_emul.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/sim/syscall_desc.hh PRE-CREATION > src/sim/syscall_emul.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/sim/process.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/sim/process.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/mem/page_table.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/mem/se_translating_port_proxy.hh > c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/sim/Process.py c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/cpu/thread_state.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/mem/page_table.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/cpu/thread_context.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/cpu/o3/thread_context.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/cpu/simple_thread.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/arch/x86/types.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/cpu/checker/thread_context.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/arch/x86/process.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/arch/x86/linux/process.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/arch/x86/process.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/arch/x86/linux/process.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/arch/sparc/process.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/arch/sparc/process.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/arch/sparc/linux/syscalls.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/arch/mips/process.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/arch/power/process.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/arch/arm/process.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/arch/generic/types.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/arch/arm/linux/process.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > > Diff: http://reviews.gem5.org/r/3696/diff/ > > > Testing > ------- > > > Thanks, > > Brandon Potter > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
