----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3748/#review9186 -----------------------------------------------------------
Ship it! Looks OK to me. Could you add pydoc documentation to the functions you've added? E.g., """This function does... Parameters are... returns...""" after the function declarations. - Jason Lowe-Power On Dec. 6, 2016, 5:45 p.m., Gabor Dozsa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3748/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2016, 5:45 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11757:ca243216ec9e > --------------------------- > arm,config: Refactor the example big.LITTLE(tm) configuration > > This patch prepares future extensions and customisation of the example > big.LITTLE configuration script. It breaks out the major phases into > functions so they can be called from other python scripts. > > Change-Id: I2cb7c207c410fe14602cf17af7482719abba6c24 > Reviewed-by: Andreas Sandberg <[email protected]> > > > Diffs > ----- > > configs/example/arm/fs_bigLITTLE.py 0d38e56356c7 > > Diff: http://reviews.gem5.org/r/3748/diff/ > > > Testing > ------- > > > Thanks, > > Gabor Dozsa > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
