----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3752/#review9200 -----------------------------------------------------------
Ship it! Looks good to me. Let me know how you'd prefer to get this pushed. - Joel Hestness On Dec. 8, 2016, 11:33 p.m., Matthew Poremba wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3752/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2016, 11:33 p.m.) > > > Review request for Default and Joel Hestness. > > > Repository: gem5 > > > Description > ------- > > Changeset 11760:676d3e045d22 > --------------------------- > ruby: Add occupancy stats to MessageBuffers > > This patch is an updated version of /r/3297. > > "The most important statistic for measuring memory hierarchy performance is > throughput, which is affected by independent variables, buffer sizing and > communication latency. It is difficult/impossible to debug performance issues > through series buffers without knowing which are the bottlenecks. For finite > buffers, this patch adds statistics for the average number of messages in the > buffer, the occupancy of the buffer slots, and number of message stalls." > > > Diffs > ----- > > src/mem/ruby/network/MessageBuffer.hh > 78ef8daecd81de0c392034809b3bc155396bf983 > src/mem/ruby/network/MessageBuffer.cc > 78ef8daecd81de0c392034809b3bc155396bf983 > > Diff: http://reviews.gem5.org/r/3752/diff/ > > > Testing > ------- > > > Thanks, > > Matthew Poremba > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
