----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3764/#review9212 -----------------------------------------------------------
Ship it! Seems reasonable to me, but I'm not an expert on this code. - Jason Lowe-Power On Dec. 15, 2016, 4:51 p.m., Curtis Dunham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3764/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2016, 4:51 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > sim: add support for checkpoint downgrading > > This commit supports the use case of transitioning tags and their > associated checkpoint rewrites out of use for whatever reason. Just > replace the upgrader() method with a downgrader() method that performs > the appropriate inverse operation. > > The tag name is still used, but only in this negative, 'zombie' state, > as it will be removed from the tags in the checkpoint and gem5 binary. > > Change-Id: If9d26cccfe8449e026762b1a72f0c2ae5a9cf2d7 > Reviewed-by: Andreas Sandberg <andreas.sandb...@arm.com> > > > Diffs > ----- > > util/cpt_upgrader.py 78ef8daecd81de0c392034809b3bc155396bf983 > > Diff: http://reviews.gem5.org/r/3764/diff/ > > > Testing > ------- > > > Thanks, > > Curtis Dunham > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
