----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3763/#review9218 -----------------------------------------------------------
Ship it! Ship It! - Mohammad Alian On Dec. 15, 2016, 4:50 p.m., Curtis Dunham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3763/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2016, 4:50 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > dist, dev: fix etherswitch upgrade script > > The aforementioned upgrader in [1] assumes every option in [system] > has a delimiting '.', and also seems to do its rewriting work a bit too > unconditionally. Most checkpoints in the wild don't have this device, > in which case this script should be a safe no-op. > > [1] 2aa4d7b dist, dev: Fixed the packet ordering in etherswitch > > Change-Id: Icfd0350985109df1628eb9ab864cda42c54060a8 > Reviewed-by: Gabor Dozsa <gabor.do...@arm.com> > > > Diffs > ----- > > util/cpt_upgraders/etherswitch.py 78ef8daecd81de0c392034809b3bc155396bf983 > > Diff: http://reviews.gem5.org/r/3763/diff/ > > > Testing > ------- > > > Thanks, > > Curtis Dunham > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
