----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3771/#review9222 -----------------------------------------------------------
Ship it! This is pretty ugly, but I guess it's important to have something that works. It shows again how inflexible the Ruby profiler is... - Jason Lowe-Power On Dec. 20, 2016, 11:55 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3771/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2016, 11:55 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11779:06c8d1e32685 > --------------------------- > ruby: guard usage of GPUCoalescer code in Profiler > > the GPUCoalescer code is used in the ruby profiler regardless of > whether or not the coalescer code has been compiled, which can > lead to link/run time errors. here we add #ifdefs to guard the > usage of GPUCoalescer code. eventually we should refactor this > code to use probe points. > > > Diffs > ----- > > SConstruct dccdf4e12a0b5814b5e5ed9c7ddf2d272aedc13c > src/mem/ruby/profiler/Profiler.cc dccdf4e12a0b5814b5e5ed9c7ddf2d272aedc13c > > Diff: http://reviews.gem5.org/r/3771/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
