----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3753/#review9246 -----------------------------------------------------------
Ship it! Ship It! - Tushar Krishna On Jan. 10, 2017, 9:42 p.m., Matthew Poremba wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3753/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2017, 9:42 p.m.) > > > Review request for Default and Tushar Krishna. > > > Repository: gem5 > > > Description > ------- > > Changeset 11792:9ee13c6fa290 > --------------------------- > ruby: Check MessageBuffer space in garnet NetworkInterface > > Garnet's NetworkInterface does not consider the size of MessageBuffers when > ejecting a Message from the network. Add a size check for the MessageBuffer > and only enqueue if space is available. If space is not available, the > message if placed in a queue and the credit is held. A callback from the > MessageBuffer is implemented to wake the NetworkInterface. If there are > messages in the stalled queue, they are processed first, in a FIFO manner > and if succesfully ejected, the credit is finally sent back upstream. The > maximum size of the stall queue is equal to the number of valid VNETs > with MessageBuffers attached. > > > Diffs > ----- > > src/mem/ruby/network/garnet2.0/flit.cc > c10c50cb8ac9d6c8dfbaa6437720a07656a3afcf > src/mem/ruby/network/garnet2.0/flitBuffer.hh > c10c50cb8ac9d6c8dfbaa6437720a07656a3afcf > src/mem/ruby/network/garnet2.0/NetworkInterface.cc > c10c50cb8ac9d6c8dfbaa6437720a07656a3afcf > src/mem/ruby/network/garnet2.0/flit.hh > c10c50cb8ac9d6c8dfbaa6437720a07656a3afcf > src/mem/ruby/network/MessageBuffer.hh > c10c50cb8ac9d6c8dfbaa6437720a07656a3afcf > src/mem/ruby/network/MessageBuffer.cc > c10c50cb8ac9d6c8dfbaa6437720a07656a3afcf > src/mem/ruby/network/garnet2.0/NetworkInterface.hh > c10c50cb8ac9d6c8dfbaa6437720a07656a3afcf > > Diff: http://reviews.gem5.org/r/3753/diff/ > > > Testing > ------- > > > Thanks, > > Matthew Poremba > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
