----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3780/#review9282 -----------------------------------------------------------
Ship it! Ship It! - Brandon Potter On Jan. 18, 2017, 5:39 p.m., Alec Roelke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3780/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2017, 5:39 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11795:3ac8305dbf60 > --------------------------- > riscv: Fix crash when syscall argument reg index is too high > > By default, doSyscall gets the values of six registers to be used for > system call arguments. RISC-V, by convention, only has four. Because > RISC-V's implementation of these indices is as arrays of integers rather > than as base indices plus offsets, trying to get the fifth argument > register's value will cause a crash. This patch fixes that by returning 0 > for any index higher than 3. > > > Diffs > ----- > > src/arch/riscv/process.cc 97eebddaae84 > > Diff: http://reviews.gem5.org/r/3780/diff/ > > > Testing > ------- > > > Thanks, > > Alec Roelke > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
