----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3778/#review9288 -----------------------------------------------------------
Ship it! Comment below is just in case anyone else was confused, like I was, as to how it's possible to remove the findObject() call. Minor: The commit message doesn't conform to the style guide. src/sim/cxx_manager.cc <http://reviews.gem5.org/r/3778/#comment7934> In case anyone else is confused as to how this works: in findTraversalOrder, first it calls findObject("root"), then it calls findObject() on each of root's children, and so on. So there wasn't any need for the findObject call here. - Jason Lowe-Power On Jan. 9, 2017, 1:53 p.m., Christian Menard wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3778/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2017, 1:53 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > There is a bug in the CxxConfig manager that may lead to Objects beeing > created in the wrong order. I noted the issue, when a System Object used a > wrong FullSystem Flag because it was constructed before the Root object. This > happens when the system has a name that comes before 'root' in aplhabetical > order. Since findObject(name) creates the Object if not yet present, all > objects are constructed in alphabetical order. This may break object > dependencies. > > > This patch fixes the bug by removing the alphabetical ordering. > > > Diffs > ----- > > src/sim/cxx_manager.cc c10c50cb8ac9 > > Diff: http://reviews.gem5.org/r/3778/diff/ > > > Testing > ------- > > > Thanks, > > Christian Menard > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
