----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3800/#review9366 -----------------------------------------------------------
Would this not spell the end of gem5 support on 32-bit platforms/kernels? Is it not possible to avoid using the non-standard type? - Andreas Hansson On Feb. 2, 2017, 12:32 a.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3800/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2017, 12:32 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11970:a7fb935f1418 > --------------------------- > x86 fix Mul1u instructions > > the Mul1uFlags and Mul1u instructions perform the 64b multiplication using > only 64b registers, however this method causes the high 64b to be corrupted > for certain inputs. to avoid this complexity, we use the compiler builtin > __uint128_t, which is supported by gcc and clang to simplify the code and > get correct results. > > > Diffs > ----- > > src/arch/x86/isa/microops/regop.isa > ed89cb178ecd7586296d2a2e83595174474db554 > > Diff: http://reviews.gem5.org/r/3800/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
