----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3823/#review9447 -----------------------------------------------------------
Ship it! Ship It! - Jason Lowe-Power On Feb. 21, 2017, 6:55 p.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3823/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2017, 6:55 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11877:0d512e211833 > --------------------------- > arch: Include generated decoder header after normal headers > > The generated decoder header defines macros that represent bit fields > within instructions. These fields typically have short names that > conflict with names in other header files. Include the generated > header after all normal header to avoid this issue. > > Change-Id: I53d149b75432c20abdbf651e32c3c785d897973b > Signed-off-by: Andreas Sandberg <andreas.sandb...@arm.com> > Reviewed-by: Curtis Dunham <curtis.dun...@arm.com> > > > Diffs > ----- > > src/arch/generic/memhelpers.hh ba90ffa751b6 > src/arch/isa_parser.py ba90ffa751b6 > > Diff: http://reviews.gem5.org/r/3823/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
