----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3822/#review9448 -----------------------------------------------------------
Why the name change ThermalNode -> thermal_entity? Wouldn't it be more clear to call the new files "thermal_node.\*"? - Jason Lowe-Power On Feb. 21, 2017, 7:02 p.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3822/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2017, 7:02 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11876:0e18f230c540 > --------------------------- > power: Avoid forward declarations that confuse wrappers > > The Python wrappers get confused by the forward declarations in the > power framework. This changeset restructures the code slightly to > avoid the troublesome forward declarations. > > Change-Id: Id8c93224f1988edb5fdf9d3abc6237f2f688c02d > Signed-off-by: Andreas Sandberg <andreas.sandb...@arm.com> > Reviewed-by: Andreas Hansson <andreas.hans...@arm.com> > Reviewed-by: Curtis Dunham <curtis.dun...@arm.com> > Reviewed-by: Sascha Bischoff <sascha.bisch...@arm.com> > > > Diffs > ----- > > src/sim/power/SConscript ba90ffa751b6 > src/sim/power/ThermalModel.py ba90ffa751b6 > src/sim/power/thermal_domain.hh ba90ffa751b6 > src/sim/power/thermal_entity.hh ba90ffa751b6 > src/sim/power/thermal_entity.cc PRE-CREATION > src/sim/power/thermal_model.hh ba90ffa751b6 > src/sim/power/thermal_model.cc ba90ffa751b6 > > Diff: http://reviews.gem5.org/r/3822/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
