----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3816/#review9474 -----------------------------------------------------------
Ship it! src/arch/arm/kvm/armv8_cpu.cc (line 253) <http://reviews.gem5.org/r/3816/#comment7982> I don't think you need this. You should be able to just load the value straight from kvm into a CPSR-typed variable. E.g.: const CPSR cpsr(getOneRegU64(...)); tc->setMiscRegNoEffect(MISCREG_CPSR, cpsr); // set CC regs ... Looks good, thanks for refactoring! - Andreas Sandberg On Feb. 23, 2017, 7:17 p.m., Rahul Thakur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3816/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2017, 7:17 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11873:f1d504c8ede4 > --------------------------- > commit 70469eba20cdcf091d66cf2ef463318203c7cc71 > Author: Slava Malyugin <[email protected]> > Date: Wed Dec 2 19:01:12 2015 -0800 > > arm, kvm: fix saving/restoring conditional flags in ARM KVM64 > > The gem5 stores flags separately from other fields CPSR, so we need to > split them out and recombine on trips to/from KVM. > > Change-Id: I9f0a685f8667c581cdef7d8c234604a3135d9402 > > > Diffs > ----- > > src/arch/arm/kvm/armv8_cpu.cc ba90ffa751b6 > > Diff: http://reviews.gem5.org/r/3816/diff/ > > > Testing > ------- > > > Thanks, > > Rahul Thakur > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
