----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3841/#review9493 -----------------------------------------------------------
Ship it! This fixes the build issues I'm experiencing with clang 3.8. Thanks! - Andreas Sandberg On Feb. 25, 2017, 7:33 p.m., Brandon Potter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3841/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2017, 7:33 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11880:7ad57dc06157 > --------------------------- > gpu-compute: mark functions with override if replacing virtual > > The clang compiler is more stringent than the recent versions of > GCC when dealing with overrides. This changeset adds the specifier > to the methods which need it to silence the compiler. > > > Diffs > ----- > > src/arch/hsail/insts/gpu_static_inst.hh > 5ea85692a53ea437c95e5a199884bd3a5266f820 > src/gpu-compute/gpu_static_inst.hh 5ea85692a53ea437c95e5a199884bd3a5266f820 > > Diff: http://reviews.gem5.org/r/3841/diff/ > > > Testing > ------- > > > Thanks, > > Brandon Potter > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
