Hello Curtis Dunham,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/2227
to review the following change.
Change subject: power: Avoid forward declarations that confuse wrappers
......................................................................
power: Avoid forward declarations that confuse wrappers
The Python wrappers get confused by the forward declarations in the
power framework. This changeset restructures the code slightly to
avoid the troublesome forward declarations.
Change-Id: Id8c93224f1988edb5fdf9d3abc6237f2f688c02d
Signed-off-by: Andreas Sandberg <andreas.sandb...@arm.com>
Reviewed-by: Andreas Hansson <andreas.hans...@arm.com>
Reviewed-by: Curtis Dunham <curtis.dun...@arm.com>
Reviewed-by: Sascha Bischoff <sascha.bisch...@arm.com>
---
M src/sim/power/SConscript
M src/sim/power/ThermalModel.py
M src/sim/power/thermal_domain.hh
A src/sim/power/thermal_entity.cc
M src/sim/power/thermal_entity.hh
M src/sim/power/thermal_model.cc
M src/sim/power/thermal_model.hh
7 files changed, 79 insertions(+), 37 deletions(-)
diff --git a/src/sim/power/SConscript b/src/sim/power/SConscript
index 2f0eb4f..16ae002 100644
--- a/src/sim/power/SConscript
+++ b/src/sim/power/SConscript
@@ -39,6 +39,7 @@
Source('power_model.cc')
Source('mathexpr_powermodel.cc')
Source('thermal_domain.cc')
+Source('thermal_entity.cc')
Source('thermal_model.cc')
DebugFlag('ThermalDomain')
diff --git a/src/sim/power/ThermalModel.py b/src/sim/power/ThermalModel.py
index 4a2f5d9..b8ed45e 100644
--- a/src/sim/power/ThermalModel.py
+++ b/src/sim/power/ThermalModel.py
@@ -45,7 +45,7 @@
# Represents a thermal node
class ThermalNode(SimObject):
type = 'ThermalNode'
- cxx_header = "sim/power/thermal_model.hh"
+ cxx_header = "sim/power/thermal_entity.hh"
# Represents a thermal resistor
class ThermalResistor(SimObject):
diff --git a/src/sim/power/thermal_domain.hh
b/src/sim/power/thermal_domain.hh
index f385994..114c9d1 100644
--- a/src/sim/power/thermal_domain.hh
+++ b/src/sim/power/thermal_domain.hh
@@ -46,9 +46,8 @@
#include "params/ThermalDomain.hh"
#include "sim/power/thermal_entity.hh"
#include "sim/sim_object.hh"
+#include "sim/sub_system.hh"
-class SubSystem;
-class ThermalNode;
template <class T> class ProbePointArg;
/**
diff --git a/src/sim/power/thermal_entity.cc
b/src/sim/power/thermal_entity.cc
new file mode 100644
index 0000000..4856fff
--- /dev/null
+++ b/src/sim/power/thermal_entity.cc
@@ -0,0 +1,57 @@
+/*
+ * Copyright (c) 2015 ARM Limited
+ * All rights reserved
+ *
+ * The license below extends only to copyright in the software and shall
+ * not be construed as granting a license to any other intellectual
+ * property including but not limited to intellectual property relating
+ * to a hardware implementation of the functionality of the software
+ * licensed hereunder. You may use the software subject to the license
+ * terms below provided that you ensure that this notice is replicated
+ * unmodified and in its entirety in all distributions of the software,
+ * modified or unmodified, in source code or in binary form.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met: redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer;
+ * redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution;
+ * neither the name of the copyright holders nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ * Authors: David Guillen Fandos
+ */
+
+
+#include "sim/power/thermal_entity.hh"
+
+#include "params/ThermalNode.hh"
+
+/**
+ * ThermalNode
+ */
+ThermalNode::ThermalNode(const ThermalNodeParams *p)
+ : SimObject(p), id(-1), isref(false), temp(0.0f)
+{
+}
+
+ThermalNode *
+ThermalNodeParams::create()
+{
+ return new ThermalNode(this);
+}
diff --git a/src/sim/power/thermal_entity.hh
b/src/sim/power/thermal_entity.hh
index fb70396..869dc7b 100644
--- a/src/sim/power/thermal_entity.hh
+++ b/src/sim/power/thermal_entity.hh
@@ -40,8 +40,25 @@
#ifndef __SIM_THERMAL_ENTITY_HH__
#define __SIM_THERMAL_ENTITY_HH__
+#include "sim/sim_object.hh"
+
class LinearEquation;
-class ThermalNode;
+struct ThermalNodeParams;
+
+/**
+ * A ThermalNode is used to connect thermal entities, such as
+ * resistors, capacitors, references and domains. It is the circuital
+ * equivalent to a voltage node.
+ */
+class ThermalNode : public SimObject
+{
+ public:
+ ThermalNode(const ThermalNodeParams *p);
+
+ int id;
+ bool isref;
+ double temp;
+};
/**
* An abstract class that represents any thermal entity which is used
diff --git a/src/sim/power/thermal_model.cc b/src/sim/power/thermal_model.cc
index 13242f6..05ce42b 100644
--- a/src/sim/power/thermal_model.cc
+++ b/src/sim/power/thermal_model.cc
@@ -41,27 +41,12 @@
#include "base/statistics.hh"
#include "params/ThermalCapacitor.hh"
-#include "params/ThermalNode.hh"
#include "params/ThermalReference.hh"
#include "params/ThermalResistor.hh"
#include "sim/clocked_object.hh"
#include "sim/linear_solver.hh"
#include "sim/power/thermal_domain.hh"
#include "sim/sim_object.hh"
-
-/**
- * ThermalNode
- */
-ThermalNode::ThermalNode(const Params *p)
- : SimObject(p), id(-1), isref(false), temp(0.0f)
-{
-}
-
-ThermalNode *
-ThermalNodeParams::create()
-{
- return new ThermalNode(this);
-}
/**
* ThermalReference
diff --git a/src/sim/power/thermal_model.hh b/src/sim/power/thermal_model.hh
index 32f34f1..d65925d 100644
--- a/src/sim/power/thermal_model.hh
+++ b/src/sim/power/thermal_model.hh
@@ -47,27 +47,10 @@
#include "params/ThermalReference.hh"
#include "params/ThermalResistor.hh"
#include "sim/clocked_object.hh"
+#include "sim/power/thermal_domain.hh"
#include "sim/power/thermal_entity.hh"
#include "sim/sim_object.hh"
-class ThermalDomain;
-
-
-/**
- * A ThermalNode is used to connect thermal entities, such as
- * resistors, capacitors, references and domains. It is the circuital
- * equivalent to a voltage node.
- */
-class ThermalNode : public SimObject
-{
- public:
- typedef SimObjectParams Params;
- ThermalNode(const Params *p);
-
- int id;
- bool isref;
- double temp;
-};
/**
* A ThermalResistor is used to model a thermal resistance between two
--
To view, visit https://gem5-review.googlesource.com/2227
To unsubscribe, visit https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id8c93224f1988edb5fdf9d3abc6237f2f688c02d
Gerrit-Change-Number: 2227
Gerrit-PatchSet: 1
Gerrit-Owner: Andreas Sandberg <andreas.sandb...@arm.com>
Gerrit-Reviewer: Curtis Dunham <curtis.dun...@arm.com>
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
